add attachment_id to metadata

[cloudmagic80]

Summary

This PR adds attachment_id to the S3 PutObject metadata for DOCMP PEGA S3 Bucket. Each attachment will now have a corresponding "attachment_id" in their metadata. (see attached). If you visit the s3 admin console, you will see it as the supporting documents = "x-amz-meta-attachment-ids"

Testing done

• New code is covered by unit tests
• Describe what the old behavior was prior to the change
• Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
• If this work is behind a flipper:
  • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
  • What is the testing plan for rolling out the feature?

Screenshots

What areas of the site does it impact?

It will only impact the DOCMP PEGA owned S3 buckets called
Box-stage
Box-prod
Box-dev

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[balexandr]

This is only going to work for 10-10D? Shouldn't we write this to work for any form? If it's form specific this logic should go in the model it's specific to i.e. models/ivc_champva/vha_10_10d.rb and not in the controller. If it's logic that can be used across all of them it can go in the service module Attachments

[cloudmagic80]

If your form wants to use this logic, you will have to modify the data structure for your form

[cloudmagic80]

You have to change the data structure of your form to : "applicants"=> and "applicant_supporting_documents"=> if you want to apply this method.

[balexandr]

Can you explain why we have to add this? The form map key/value above doesn't have colons.

[cloudmagic80]

For 1010D it does.

[balexandr]

Really? The map is '10-10D' => 'vha_10_10d', when does the colon come into play?

[balexandr]

Why couldn't we include this in the metadata itself? Why does it have to be a new argument?

[cloudmagic80]

Some forms don't require attachments

[balexandr]

This could happen much sooner, no?

[cloudmagic80]

No. Not all forms