API-35479-526-mock-data

[stiehlrod]

Summary

• Adds mocking for 526 pdf generator.
• Adds mock service for s3 upload

Related issue(s)

• API-35479

Testing done

• New code is covered by unit tests

• How to test in Postman

  1. {{uri}}/services/claims/v2/veterans/{{veteran_id}}/526/synchronous
  2. no headers, ccg
  3. settings.claims_api.benefits_documents.use_mocks: true
  4. Settings.evss.mock_claims: true
  5. "scope": "system/526.override system/526-pdf.override system/claim.write system/claim.read claim.write claim.read"

What areas of

the site does it impact?
modified: modules/claims_api/app/sidekiq/claims_api/v2/disability_compensation_benefits_documents_uploader.rb
modified: modules/claims_api/app/sidekiq/claims_api/v2/disability_compensation_pdf_generator.rb
modified: modules/claims_api/spec/sidekiq/v2/disability_compensation_pdf_generator_spec.rb
modified: modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb
modified: modules/claims_api/spec/sidekiq/v2/disability_compensation_benefits_documents_uploader_spec.rb

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[mchristiansonVA]

Tested 526 submissions locally using the new pdf_generator_526 setting set to true, then confirmed expected mocking behavior and associated logging. Looks good, but deferring approval for your review of comments I added.

[mchristiansonVA]

Tested locally in Postman with local settings updated as noted. Successful requests for synchronous and non-synchronous calls; confirmed pdf generation and s3 upload are skipped. Looks good to me!