Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

82557: Add all the logic to handle DB insertion with uploads controller #16701

Merged
merged 12 commits into from
May 15, 2024

Conversation

balexandr
Copy link
Contributor

@balexandr balexandr commented May 9, 2024

In support of sending an email update to a VFMP applicant, the PEGA response that represents the applicants data needs to be stored in the VA.gov back end.

This is Part A of this ticket as it handles the initial DB insertion and setup for part B

Summary

  • Update database to remove email uniqueness index; Add index for form_uuid
  • Update model to remove validation
  • Update existing models to include email and uuid
  • Add DB creation when file is being uploaded
  • Add Rspec to ensure database record is being added
  • Update existing tests

Related issue(s)

Screenshots

Screenshot 2024-05-09 at 4 42 02 PM

Testing done

  • Rspec tests
  • Manual tests

Acceptance criteria

Given a well-formed call to the callback endpoint
When the response is received
Then the response should be persisted so that status can be send back to the applicantexpected

@va-vfs-bot va-vfs-bot temporarily deployed to 82557-part-a-map-pega-responses-to-be/main/main May 9, 2024 20:12 Inactive
…emove primary contact info from metadata to Pega
@balexandr balexandr marked this pull request as ready for review May 9, 2024 21:07
@balexandr balexandr requested review from a team as code owners May 9, 2024 21:07
michaelclement
michaelclement previously approved these changes May 9, 2024
cloudmagic80
cloudmagic80 previously approved these changes May 9, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to 82557-part-a-map-pega-responses-to-be/main/main May 9, 2024 21:53 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 82557-part-a-map-pega-responses-to-be/main/main May 10, 2024 13:59 Inactive
michaelclement
michaelclement previously approved these changes May 10, 2024
cloudmagic80
cloudmagic80 previously approved these changes May 10, 2024
@balexandr balexandr enabled auto-merge (squash) May 10, 2024 17:13
@va-vfs-bot va-vfs-bot temporarily deployed to 82557-part-a-map-pega-responses-to-be/main/main May 10, 2024 18:00 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 82557-part-a-map-pega-responses-to-be/main/main May 10, 2024 18:28 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 82557-part-a-map-pega-responses-to-be/main/main May 10, 2024 18:56 Inactive
michaelclement
michaelclement previously approved these changes May 10, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to 82557-part-a-map-pega-responses-to-be/main/main May 10, 2024 20:55 Inactive
cloudmagic80
cloudmagic80 previously approved these changes May 10, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to 82557-part-a-map-pega-responses-to-be/main/main May 15, 2024 00:24 Inactive
@balexandr balexandr merged commit adb4a91 into master May 15, 2024
19 checks passed
@balexandr balexandr deleted the 82557-part-a-map-pega-responses-to-be branch May 15, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants