#82765 [10-10EZR]: Add/update a form submission's veteranDateOfBirth if it's missing or blank

[JoshingYou1]

Summary

• Adds a method to "post-fill" veteranDateOfBirth in the form params if it's missing or blank. We'll utilize the current_user's session by setting the form value to the birth_date value. This is to hopefully resolve the schema validation error related to veteranDateOfBirth we've been seeing on and off.

Related issue(s)

• [BE] 10-10EZR - Add the current_user's DOB to the form params if 'veteranDateOfBirth' is missing or blank va.gov-team#82765

Testing done

• New code is covered by unit tests

What areas of the site does it impact?

• 10-10EZR form

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

[dellerbie]

Curious if you want to log or send a metric to DD when this post-fill happens? That way we'll know how often it's taking place and for who

[JoshingYou1]

That would be cool! Did you have something in mind for tracking the "who" in these scenarios? I'm fairly certain logging PHI is frowned upon unless it's for something important. Also, regarding logging, do you mean like a regular rails log or something more robust? The problem with rails logs is I think we'd probably run into an issue of tracking WHEN this occurs. What do you think?

[dellerbie]

non-blocking comments/questions

[dellerbie]

Almost feel like you don't need the if since parsed_form['veteranDateOfBirth'] is nil already when this line executes; you would just be setting it to nil again, which it already is. One less conditional

[JoshingYou1]

Agreed! It has been removed. Thanks Derrick!