Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-34441 action poa request spike #16692

Merged
merged 1 commit into from
May 15, 2024

Conversation

nihil2501
Copy link
Contributor

@nihil2501 nihil2501 commented May 8, 2024

just the basic bgs operation without much of the necessary surrounding infrastructure like validation
picked up a couple restructures to share logic with poa request search already, with more coming

@nihil2501 nihil2501 added the claimsApi modules/claims_api label May 8, 2024
Copy link

github-actions bot commented May 8, 2024

1 Warning
⚠️ This PR changes 334 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • modules/claims_api/app/clients/claims_api/bgs_client/service_action.rb (+14/-0)

  • modules/claims_api/app/controllers/claims_api/v2/power_of_attorney_request/base_controller.rb (+32/-0)

  • modules/claims_api/app/controllers/claims_api/v2/power_of_attorney_request/decisions_controller.rb (+39/-0)

  • modules/claims_api/app/controllers/claims_api/v2/power_of_attorney_requests_controller.rb (+11/-19)

  • modules/claims_api/app/services/claims_api/power_of_attorney_request_service/decide.rb (+41/-0)

  • modules/claims_api/app/services/claims_api/power_of_attorney_request_service/helpers/xml_builder.rb (+32/-0)

  • modules/claims_api/app/services/claims_api/power_of_attorney_request_service/search.rb (+14/-31)

  • modules/claims_api/config/routes.rb (+7/-1)

  • modules/claims_api/spec/requests/v2/power_of_attorney_requests/decline/request_spec.rb (+65/-0)

  • modules/claims_api/spec/requests/v2/power_of_attorney_requests/index/request_spec.rb (+12/-16)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34441/action-poa-request.spike/main/main May 9, 2024 00:00 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34441/action-poa-request.spike/main/main May 9, 2024 07:48 Inactive
@nihil2501 nihil2501 force-pushed the dash/oren/API-34441/action-poa-request.spike branch from e67b02c to 9ccf78b Compare May 10, 2024 06:05
@nihil2501 nihil2501 requested a review from FonzMP May 10, 2024 06:08
FonzMP
FonzMP previously approved these changes May 13, 2024
Copy link
Contributor

@FonzMP FonzMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Base automatically changed from dash/oren/API-34439/read-poa-request-pagination to master May 15, 2024 17:57
@nihil2501 nihil2501 dismissed FonzMP’s stale review May 15, 2024 17:57

The base branch was changed.

just the basic bgs operation without much of the necessary surrounding infrastructure like validation
picked up a couple restructures to share logic with poa request search already, with more coming
@nihil2501 nihil2501 force-pushed the dash/oren/API-34441/action-poa-request.spike branch from 9ccf78b to e2c8f4c Compare May 15, 2024 18:03
@nihil2501 nihil2501 marked this pull request as ready for review May 15, 2024 18:22
@nihil2501 nihil2501 requested a review from a team as a code owner May 15, 2024 18:22
@nihil2501 nihil2501 requested a review from FonzMP May 15, 2024 18:39
Copy link
Contributor

@FonzMP FonzMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@nihil2501 nihil2501 merged commit 35f5814 into master May 15, 2024
19 checks passed
@nihil2501 nihil2501 deleted the dash/oren/API-34441/action-poa-request.spike branch May 15, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants