Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIMPLE_FORMS] feat: 21-4138 - data mapping #16688

Merged
merged 9 commits into from
May 14, 2024
Merged

[SIMPLE_FORMS] feat: 21-4138 - data mapping #16688

merged 9 commits into from
May 14, 2024

Conversation

pennja
Copy link
Contributor

@pennja pennja commented May 8, 2024 •
edited

Summary

This PR adds backend data mapping for form 21-4138, including signature stamping on the last page.

Related issue(s)

Testing done

  • New code is covered by unit tests

Screenshots

@pennja pennja changed the title 21-4138: backend mapping [SIMPLE_FORMS] feat: 21-4138 - data mapping May 8, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to jap/simple-forms/1184-21-4138-backend-mapping/main/main May 8, 2024 21:55 Inactive
@pennja pennja force-pushed the jap/simple-forms/1184-21-4138-backend-mapping branch from 5d4f7c1 to a95a2e9 Compare May 9, 2024 19:08
@va-vfs-bot va-vfs-bot temporarily deployed to jap/simple-forms/1184-21-4138-backend-mapping/main/main May 9, 2024 20:06 Inactive
@pennja pennja force-pushed the jap/simple-forms/1184-21-4138-backend-mapping branch from a95a2e9 to da71d3d Compare May 10, 2024 14:11
@va-vfs-bot va-vfs-bot temporarily deployed to jap/simple-forms/1184-21-4138-backend-mapping/main/main May 10, 2024 14:12 Inactive
@pennja pennja marked this pull request as ready for review May 10, 2024 14:17
@pennja pennja requested review from a team as code owners May 10, 2024 14:17
@va-vfs-bot va-vfs-bot temporarily deployed to jap/simple-forms/1184-21-4138-backend-mapping/main/main May 10, 2024 14:22 Inactive
Thrillberg
Thrillberg reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@Thrillberg Thrillberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably leave track_user_identity blank for now. I think Tricia usually assigns that as a separate task.

modules/simple_forms_api/app/models/simple_forms_api/vba_21_4138.rb Outdated Show resolved Hide resolved
modules/simple_forms_api/spec/fixtures/form_json/vba_21_4138-min.json Show resolved Hide resolved
@pennja pennja force-pushed the jap/simple-forms/1184-21-4138-backend-mapping branch from 8eeedbb to 9868176 Compare May 10, 2024 15:18
rmtolmach
rmtolmach approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@rmtolmach rmtolmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are the codeowners of all of these files except lib/pdf_fill/forms/pdfs/21-4138.pdf. If you rightfully own that file and want control over it, add an entry to CODEOWNERS and I'll re-approve the PR.

@pennja pennja merged commit c6df9ba into master May 14, 2024
19 checks passed
@pennja pennja deleted the jap/simple-forms/1184-21-4138-backend-mapping branch May 14, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thrillberg Thrillberg Thrillberg approved these changes

@rmtolmach rmtolmach rmtolmach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pennja @Thrillberg @rmtolmach @va-vfs-bot