Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-17962: Adds the form upload field to VA Forms. #18096

Merged
merged 3 commits into from
May 14, 2024

Conversation

dsasser
Copy link
Contributor

@dsasser dsasser commented May 9, 2024

Description

Relates to #17962

Testing done

Tested that field exists on VA Form

Screenshots

screencapture-va-gov-cms-ddev-site-node-add-va-form-2024-05-09-08_42_42

QA steps

As a Content Admin

  1. Visit node/add/va_form
    • Validate that the Form Upload field exists

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat May 9, 2024 17:35 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat May 9, 2024 17:42 Destroyed
@va-cms-bot
Copy link
Collaborator

va/tests/status-error:


entity_update
Title Entity/field definitions
Severity Error
Sid 2
Description The following changes were detected in the entity type and field definitions.
.... Content

         * The /node.field_datetime_range_timezone/ field needs to be updated.        
                                                                                      
        .... Paragraph                                                                
                                                                                      
         * The /paragraph.field_datetime_range_timezone/ field needs to be updated.   

Value Mismatched entity and/or field definitions

@va-cms-bot va-cms-bot temporarily deployed to Tugboat May 9, 2024 17:48 Destroyed
@dsasser dsasser requested a review from edmund-dunn May 10, 2024 17:56
@omahane omahane self-requested a review May 14, 2024 16:06
Copy link
Contributor

@omahane omahane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I also edited a pre-existing form and checked the element and saved the form without issue.

@dsasser dsasser merged commit 2e19c43 into main May 14, 2024
20 checks passed
@dsasser dsasser deleted the VACMS-17962-forms-react-widget-field branch May 14, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants