Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VACMS-17374: spike remove ief vet center services #17664

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

VACMS-17374: spike remove ief vet center services #17664

wants to merge 8 commits into from
+988 −30

Conversation

omahane
Copy link
Contributor

@omahane omahane commented Mar 27, 2024

Description

Relates to

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As user uid with user_role

  1. Do this
    • Validate that
  2. Then
    • Validate that
  3. Then validate Acceptance Criteria from issue
    • a
    • b
    • c

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 27, 2024 19:14 Destroyed
@github-actions github-actions bot changed the title Vacms 17374 spike remove ief vet center services VACMS-17374: spike remove ief vet center services Mar 27, 2024
@github-actions github-actions bot added the DO NOT MERGE Do not merge this PR label Mar 27, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 28, 2024 18:22 Destroyed
@omahane omahane force-pushed the VACMS-17374-spike-remove-ief-vet-center-services branch from c59a3ad to 35302cd Compare March 28, 2024 22:33
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 28, 2024 22:33 Destroyed
github-actions[bot]
github-actions bot reviewed Mar 28, 2024
View reviewed changes
docroot/modules/custom/va_gov_vet_center/va_gov_vet_center.module
@@ -187,6 +187,28 @@ function va_gov_vet_center_form_node_form_alter(array &$form, FormStateInterface
if ($form_state->getformObject()->getEntity()->bundle() === 'vet_center') {
$form['#attached']['library'][] = 'va_gov_vet_center/set_ief_service_selects';
}

// $form['header'] = [
// '#type' => 'fieldset',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [PHP_CodeSniffer] <Drupal.Commenting.InlineComment.SpacingBefore> reported by reviewdog 🐶
Comment indentation error, expected only 1 spaces

docroot/modules/custom/va_gov_vet_center/va_gov_vet_center.module
// '#weight' => 0,
// '#collapsible' => TRUE,
// 'title' => [
// '#markup' => '<div class="description">CBU04905 view</div>',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [PHP_CodeSniffer] <Drupal.Commenting.InlineComment.SpacingBefore> reported by reviewdog 🐶
Comment indentation error, expected only 3 spaces

docroot/modules/custom/va_gov_vet_center/va_gov_vet_center.module
// '#collapsible' => TRUE,
// 'title' => [
// '#markup' => '<div class="description">CBU04905 view</div>',
// ],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [PHP_CodeSniffer] <Drupal.Commenting.InlineComment.SpacingAfter> reported by reviewdog 🐶
There must be no blank line following an inline comment

docroot/modules/custom/va_gov_vet_center/va_gov_vet_center.module
// '#collapsible' => TRUE,
// 'title' => [
// '#markup' => '<div class="description">CBU04905 view</div>',
// ],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [PHP_CodeSniffer] <DrupalPractice.Commenting.CommentEmptyLine.SpacingAfter> reported by reviewdog 🐶
There must be no blank line following an inline comment

@va-cms-bot va-cms-bot temporarily deployed to Tugboat April 9, 2024 14:49 Destroyed
@omahane omahane force-pushed the VACMS-17374-spike-remove-ief-vet-center-services branch from 0a6c3ed to e8bc82f Compare April 9, 2024 14:51
@va-cms-bot va-cms-bot temporarily deployed to Tugboat April 9, 2024 14:51 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat April 9, 2024 14:56 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat April 17, 2024 18:12 Destroyed
@va-cms-bot
Copy link
Collaborator

Tugboat has finished building the preview for this pull request!

Links:

Dashboard:

@va-cms-bot
Copy link
Collaborator

va/tests/status-error:



entity_update

Title       Entity/field definitions

Severity    Error

Sid         2

Description The following changes were detected in the entity type and field definitions.

.... Content


         * The /node.field_datetime_range_timezone/ field needs to be updated.        
                                                                                      
        .... Paragraph                                                                
                                                                                      
         * The /paragraph.field_datetime_range_timezone/ field needs to be updated.   



Value       Mismatched entity and/or field definitions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
DO NOT MERGE Do not merge this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@omahane @va-cms-bot