VACMS-16300: Update audits/views for service location changes #17479

Becapa · 2024-03-11T17:16:46Z

Description

Relates to #16300.
This can't be merged until after the integration-service-location branch is merged into main and validated.

Removes the fields that will no longer be included on the facility services content type.

Testing done

Manually Tested

QA steps

As an administrator

Browse to the Service Locations Detailed Audit (/admin/content/audit/service-locations-detailed)
- Validate that the following columns have been removed:
  - field_hservice_appt_intro_select ('OLD: Appointment intro text')
  - field_hservice_appt_leadin ('OLD: Appointment lead-in text')
  - field_online_scheduling_availabl ('OLD: Is online scheduling available for this service?')
  - field_walk_ins_accepted ('OLD: Are walkins accepted?')
  - field_phone_numbers_paragraph ('OLD: Phone number for appointments')
Browse to the VAMC Facility Health Services view (/admin/content/facilities/vamc-facility-health-services)
- Validate that the following columns have been removed:
  - field_walk_ins_accepted ('Walkins accepted')
  - field_online_scheduling_availabl ('Online scheduling')
- Validate that the following exposed filters have been removed:
  - field_walk_ins_accepted_value ('Walkins accepted')
  - field_online_scheduling_availabl_value ('Online scheduling')

Definition of Done

Documentation has been updated, if applicable.
Tests have been added if necessary.
Automated tests have passed.
Code Quality Tests have passed.
Acceptance Criteria in related issue are met.
Manual Code Review Approved.
If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

Is this PR blocked by another PR?

DO NOT MERGE

Does this PR need review from a Product Owner

Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

Yes, and it's written in issue ____ and queued for publication.
- Merge and ping the UX writer so they are ready to publish after deployment
Yes, but it hasn't yet been written
- Don't merge yet -- ping the UX writer to write and queue content
No announcement is needed for this code change.
- Merge & carry on unburdened by announcements

omahane

This looks right and meets the ACs.

I noticed that the "New:" in the column headers of the first view are no longer relevant after the old fields are removed. Should we change those labels?

Becapa · 2024-03-14T16:39:41Z

This looks right and meets the ACs.

I noticed that the "New:" in the column headers of the first view are no longer relevant after the old fields are removed. Should we change those labels?

That makes sense to me! I'll fix those up right quick.

github-actions · 2024-03-14T16:48:49Z

GitHub Workflows (.github/workflows/*.yml)

Have you...

pinned all affected GitHub Actions at a specific commit by SHA?
reviewed the source code of the action at the commit you are pinning?
confirmed that no GitHub security measures are being bypassed?
checked for any injection of user content into protected contexts?
reviewed Security hardening for GitHub Actions?
reviewed GitHub Workflows?

va-cms-bot · 2024-03-14T16:57:12Z

va/tests/status-error:

entity_update
Title Entity/field definitions
Severity Error
Sid 2
Description The following changes were detected in the entity type and field definitions.
.... Content

         * The /node.field_address/ field needs to be updated.                        
         * The /node.field_mailing_address/ field needs to be updated.                
         * The /node.field_vamc_med_records_mailing/ field needs to be updated.       
                                                                                      
        .... Paragraph                                                                
                                                                                      
         * The /paragraph.field_address/ field needs to be updated.

Value Mismatched entity and/or field definitions

omahane

This looks great.

We'll need to rebase this branch once integration-service-location is merged.

* VACMS:14704: Adding service modalities * VACMS-14704: Adds vocabulary * VACMS-14704: Adds free-text fields. * VACMS-14704: Update langage around service delivery * VACMS-14704: Updates taxonomy label and description

* VACMS-14704: Adding service location fields (#15599) * VACMS:14704: Adding service modalities * VACMS-14704: Adds vocabulary * VACMS-14704: Adds free-text fields. * VACMS-14704: Update langage around service delivery * VACMS-14704: Updates taxonomy label and description * VACMS-16348: Removes unnecessary and undesired fields * VACMS-16348: Adds service options, office hours and virtual support * VACMS-16348: Adds appointment fields * VACMS-16348: Adds online scheduling field * VACMS-16348: Adds a necessary question mark * VACMS-16348: Updates description for office visits

* VACMS-14704: Adding service location fields (#15599) * VACMS:14704: Adding service modalities * VACMS-14704: Adds vocabulary * VACMS-14704: Adds free-text fields. * VACMS-14704: Update langage around service delivery * VACMS-14704: Updates taxonomy label and description * VACMS-16348: Removes unnecessary and undesired fields * VACMS-16348: Shows Custom text when Customize text is selected * VACMS-16348: Trying to get the default text * VACMS-16348: Adds default text to Service Locations for VAMC facility health and Service region * VACMS-16348: Removes VAMC Facility Health Service-level appointment code * VACMS-16348: Adds VBA Facility service appt lead-in default text * VACMS-16348: Adds VBA FAcility service appt default text UX * VACMS-16348: DRYing off this code for the different content types and fields * VACMS-16348: Adds nonclinical service default text field * VACMS-16348: Restores the errant revision_log and adds right field for vba_facility_service * VACMS-16348: Moves work out of backend and vamc and into facilities * VACMS-16348: Trying to get paragraph validation to work * VACMS-16348: Adds required state to custom text * VACMS-16348: Removes text validation, as not working, for now * VACMS-16348: Removing commented out code

…tion (#17225) * VACMS-17142: Update cypress test to use phone number in service locations * VACMS-17142: Hide VAMC Facility Health Service fields that are no longer in use. * VACMS-17142: Have the view_display mirror the form_display. * VACMS-17142: Add revision_log back. * VACMS-17142: Update service location paragraph view display to mirror form display.

…on-changes

dsasser

Looks good!

va-cms-bot · 2024-05-21T21:56:01Z

Tugboat has finished building the preview for this pull request!

Links:

Dashboard:

https://tugboat.vfs.va.gov/65ef3c81934120388305f020

Becapa added the DO NOT MERGE Do not merge this PR label Mar 11, 2024

va-cms-bot temporarily deployed to Tugboat March 11, 2024 17:16 Destroyed

github-actions bot added the Facilities Facilities products (VAMC, Vet Center, etc) label Mar 11, 2024

va-cms-bot temporarily deployed to Tugboat March 12, 2024 13:07 Destroyed

Becapa force-pushed the VACMS-16300-update-audits-for-service-location-changes branch from bee16f7 to 197fc89 Compare March 12, 2024 15:34

va-cms-bot temporarily deployed to Tugboat March 12, 2024 15:35 Destroyed

omahane self-requested a review March 14, 2024 16:34

omahane reviewed Mar 14, 2024

View reviewed changes

va-cms-bot temporarily deployed to Tugboat March 14, 2024 16:48 Destroyed

omahane reviewed Mar 14, 2024

View reviewed changes

davidmpickett mentioned this pull request Mar 27, 2024

Launch plan for VBA/VAMC Service Locations enhancements #16825

Closed

64 tasks

jilladams mentioned this pull request Mar 28, 2024

Update audits/views for Service Locations changes #16300

Open

16 tasks

omahane and others added 6 commits May 13, 2024 11:50

VACMS-14704: Adding service location fields (#15599)

560db80

* VACMS:14704: Adding service modalities * VACMS-14704: Adds vocabulary * VACMS-14704: Adds free-text fields. * VACMS-14704: Update langage around service delivery * VACMS-14704: Updates taxonomy label and description

VACMS-15649: Removes free text fields from service location (#15676)

408d661

VACMS-16300: Remove hidden fields from views.

cc52be8

omahane force-pushed the VACMS-16300-update-audits-for-service-location-changes branch from 2ae7b13 to cc52be8 Compare May 13, 2024 17:08

va-cms-bot temporarily deployed to Tugboat May 13, 2024 17:08 Destroyed

va-cms-bot temporarily deployed to Tugboat May 13, 2024 17:31 Destroyed

VACMS-16300: Restores office visits

19e1933

omahane force-pushed the VACMS-16300-update-audits-for-service-location-changes branch from f3501f4 to 19e1933 Compare May 13, 2024 17:36

va-cms-bot temporarily deployed to Tugboat May 13, 2024 17:36 Destroyed

VACMS-16300: Restores VBA from main

9351f48

va-cms-bot temporarily deployed to Tugboat May 13, 2024 17:41 Destroyed

VACMS-16300: Removes NEW:s from the views

eb6d5c0

va-cms-bot temporarily deployed to Tugboat May 13, 2024 18:00 Destroyed

Merge branch 'main' into VACMS-16300-update-audits-for-service-locati…

ed4268c

…on-changes

va-cms-bot temporarily deployed to Tugboat May 14, 2024 16:38 Destroyed

jilladams removed the DO NOT MERGE Do not merge this PR label May 15, 2024

jilladams assigned omahane May 15, 2024

jilladams requested a review from dsasser May 15, 2024 16:48

dsasser approved these changes May 15, 2024

View reviewed changes

omahane marked this pull request as ready for review May 15, 2024 17:59

va-cms-bot deployed to Tugboat May 21, 2024 21:09 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VACMS-16300: Update audits/views for service location changes #17479

VACMS-16300: Update audits/views for service location changes #17479

Becapa commented Mar 11, 2024 •

edited by omahane

omahane left a comment

Becapa commented Mar 14, 2024

github-actions bot commented Mar 14, 2024

va-cms-bot commented Mar 14, 2024

omahane left a comment

dsasser left a comment

va-cms-bot commented May 21, 2024

VACMS-16300: Update audits/views for service location changes #17479

Are you sure you want to change the base?

VACMS-16300: Update audits/views for service location changes #17479

Conversation

Becapa commented Mar 11, 2024 • edited by omahane

Description

Testing done

QA steps

Definition of Done

Select Team for PR review

Is this PR blocked by another PR?

Does this PR need review from a Product Owner

CMS user-facing announcement

omahane left a comment

Choose a reason for hiding this comment

Becapa commented Mar 14, 2024

github-actions bot commented Mar 14, 2024

GitHub Workflows (.github/workflows/*.yml)

va-cms-bot commented Mar 14, 2024

omahane left a comment

Choose a reason for hiding this comment

dsasser left a comment

Choose a reason for hiding this comment

va-cms-bot commented May 21, 2024

Becapa commented Mar 11, 2024 •

edited by omahane