-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tugboat Next.js server can be restarted via Composer command #17400
base: main
Are you sure you want to change the base?
Conversation
This reverts commit dfc8eec.
Co-authored-by: Tim Cosgrove <timcosgrove@users.noreply.github.com>
Co-authored-by: Tim Cosgrove <timcosgrove@users.noreply.github.com>
Co-authored-by: Tim Cosgrove <timcosgrove@users.noreply.github.com>
Tugboat has finished building the preview for this pull request! Links:
Dashboard: |
#pushd "./next" | ||
yarn install | ||
#popd | ||
# @todo Should the manual steps go here like copying the .env file? or maybe in next-start.sh? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to delete this comment but don't want to rebuild Tugboat before a review.
|
||
# Start the dev server. Vets-website assets need to be in place prior to this build. | ||
APP_ENV=tugboat yarn start | ||
# Need to start in the background so the script can exit. | ||
APP_ENV=${APP_ENV} yarn start &> /dev/null & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am unsure if running in the background is needed but I think the script paused and didn't continue. However, output isn't logged this way so might need adjusting to get output in logs if desired.
Description
closes #17209 by adding commands to restart the next server after changing git branches.
Testing done
Tested on Tugboat with a test branch that makes the next-build footer red and switched between that branch and others.
Screenshots
test-red-footer
branch on TugboatQA steps
test-red-footer
branch for next-build version and something else for the vets-website version.next-build.txt
file link leads to a log file with data in it. The log should grow every time you refresh and end with==> Done
.Note: This PR, department-of-veterans-affairs/next-build#451, should be deleted after testing.
Definition of Done
Select Team for PR review
CMS Team
Public websites
Facilities
User support
Accelerated Publishing