Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create catalog-info.yaml #17341

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Create catalog-info.yaml #17341

wants to merge 5 commits into from

Conversation

mchelen-gov
Copy link
Contributor

Description

Relates to #issueid. (or closes?)

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As user uid with user_role

  1. Do this
    • Validate that
  2. Then
    • Validate that
  3. Then validate Acceptance Criteria from issue
    • a
    • b
    • c

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 26, 2024 21:20 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 26, 2024 21:29 Destroyed
timcosgrove
timcosgrove previously approved these changes Mar 18, 2024
Copy link
Contributor

@timcosgrove timcosgrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know all the specifics of what is required by CODE VA, but if nothing else these files should not interfere with CMS operation.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 18, 2024 18:24 Destroyed
mkdocs.yaml Outdated Show resolved Hide resolved
@CoryTrimmUSDS
Copy link

Alright, I had a chance to look at this PR - I think we need to decide if we want to flesh out the side-nav a bit more.

Based on the current implementation, it would only show the README.md file and none of the other docs that are in that repo.

Also, I think the edit_uri may need to be a fully resolvable URL (similar to this) - I am near certain that all this does is render the icon in the screenshot below -
image

Thoughts on this @timcosgrove or @EWashb ?

@EWashb
Copy link
Contributor

EWashb commented Mar 21, 2024

@CoryTrimmUSDS I agree. It looks like your solution provides a much better user experience.

@mchelen-gov
Copy link
Contributor Author

FWIW 100% agree, sidenav was on my todo 😁

Created more extensive `mkdocs.yml` based on the Table of Contents in the main `README.md` file.
@va-cms-bot va-cms-bot temporarily deployed to Tugboat April 3, 2024 12:27 Destroyed
@va-cms-bot
Copy link
Collaborator

va/tests/status-error:


entity_update
Title Entity/field definitions
Severity Error
Sid 2
Description The following changes were detected in the entity type and field definitions.
.... Content

         * The /node.field_datetime_range_timezone/ field needs to be updated.        
                                                                                      
        .... Paragraph                                                                
                                                                                      
         * The /paragraph.field_datetime_range_timezone/ field needs to be updated.   

Value Mismatched entity and/or field definitions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants