Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/keli.3375 react redux update #3515

Conversation

keli13
Copy link
Contributor

@keli13 keli13 commented Jul 19, 2022

Description of Change

Updated

  • react-redux 7.2.6 to 8.0.2
  • @reduxjs/toolkit 1.6.2 to 1.8.3

Removed

  • @types/react-redux - as stated in v8 of react-redux they have converted all their files to be .ts files and no longer need these typings.

Added

  • @types/react-dom 18.0.6 - this library was added as a workaround for the following error that was occurring after updating react-redux:
    node_modules/react-redux/es/utils/reactBatchedUpdates.d.ts(1,41): error TS2307: Cannot find module 'react-dom' or its corresponding type declarations
    • There was a related fix found here that should have fixed the problem but did not work in our case.
    • Attempt to patch the library did not resolve the issue either and the alternative to set skipLibCheck to true in our tsconfig is something we should discuss.

Screenshots/Video

Testing

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

@keli13 keli13 merged commit 7aeea3c into feature-xl/dependency-updates-jun-2022 Jul 20, 2022
@keli13 keli13 deleted the feature/keli.3375-ReactReduxUpdate branch July 20, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants