v3 TODO

This is a working list of tasks remaining for the v3 implementation to send e-mail and SMS notifications. Also see the checklist in the description for #1361.

Bugs

• #1501 Sending e-mail quit working after most recent commit
• #1493 Can't save notifications with invalid template ID; can't GET notifications with mismatched template type
• Callbacks: Sent notification status doesn't update beyond "sent". (Why doesn't the existing callback functionality work for v3?) This was the case before the commit that lead to #1501 (above)
  • Existing callback code is modified to make use of the new new notification validation failure table

Missing Features

• #1518 E-mail logic in app/celery/v3/notification_tasks.py contains a lot of commented out code, which means the behavior diverges from v2. Restore the behavior.
• #1502 and #1503 Personalization (the raw template is sent now)
• #1505 Implement sending with providers other than Pinpoint and SES
• #1504 SMS default sender logic
• Implement fetching contact info with a recipient ID, also related to preference lookup logic (communication item)
• Whitelist: API Team Key and Service Restricted Mode
• Research/Delivery Simulation: API Test Key and Service Research Mode
• Delivery Status Callbacks (see bug list)
• Sending with scheduled_for (see here)
• statsd reporting (might already work)
• Onsite notifications occur when appropriate. See vanotify-team 975.
• Make sure sending international SMS works. See here.

Misc

• #1534 optimizations and TODOs