Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update loofah #469

Merged
merged 2 commits into from Oct 24, 2019
Merged

Update loofah #469

merged 2 commits into from Oct 24, 2019

Conversation

devin-mccurdy
Copy link
Contributor

@devin-mccurdy devin-mccurdy commented Oct 24, 2019 •
edited by zurbergram

https://github.com/department-of-veterans-affairs/vets.gov-team/issues/19824

Update loofah to resolve security vulnerability

Updated rake version to resolve:


  In Gemfile:
    jquery-ui-rails was resolved to 6.0.1, which depends on
      railties (>= 3.2.16) was resolved to 5.2.3, which depends on
        rake (>= 0.8.7)

    scss_lint was resolved to 0.58.0, which depends on
      rake (< 13, >= 0.9)

flavorjones/loofah#171

@devin-mccurdy devin-mccurdy requested a review from a team as a code owner October 24, 2019 13:30
@devin-mccurdy devin-mccurdy added the BAH Booz Allen Hamilton label Oct 24, 2019
shawkey-daniel
shawkey-daniel approved these changes Oct 24, 2019
View reviewed changes
Copy link

@shawkey-daniel shawkey-daniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jholton
jholton approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@jholton jholton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@devin-mccurdy devin-mccurdy merged commit c4bab5e into master Oct 24, 2019
@devin-mccurdy devin-mccurdy deleted the update-loofah branch October 24, 2019 14:58
@desireeturner desireeturner added this to the BAH Sprint 32 milestone Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jholton jholton jholton approved these changes

@shawkey-daniel shawkey-daniel shawkey-daniel approved these changes

@zurbergram zurbergram Awaiting requested review from zurbergram

Assignees
No one assigned
Labels
BAH Booz Allen Hamilton
Projects
None yet
Milestone
BAH Sprint 32
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@devin-mccurdy @jholton @shawkey-daniel @desireeturner