Alert for VVA and VBMS document list retrievals #8276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove shortcut to return null on nil manifest timestamp values that kept error messages from displaying * Add check for nil VBMS manifest timestamp References #6049
* Add check for stale manifests * Add warning alert for stale manifests
* Rename alert component * Correctly parse manifest time strings * Add test for _not quite_ so old manifest retrieval time Still needs copy from design on verbiage References #6049
ghost
assigned 
Generated by 🚫 Danger |
mdbenjam
reviewed
Dec 17, 2018
mdbenjam
reviewed
Dec 17, 2018
mdbenjam
reviewed
Dec 17, 2018
mdbenjam
reviewed
Dec 17, 2018
mdbenjam
reviewed
Dec 17, 2018
mdbenjam
reviewed
Dec 17, 2018
mdbenjam
reviewed
Dec 18, 2018
mdbenjam
reviewed
Dec 18, 2018
There was a problem hiding this comment.
Might also be good to update vbms.rb in our initializers to have something like:
if ApplicationController.dependencies_faked?
VBMSService.manifest_vbms_fetched_at = Time.zone.now
VBMSService.manifest_vva_fetched_at = Time.zone.now
end
So that our default dev data is not to show the big red alert.
mdbenjam
reviewed
Dec 18, 2018
* Update the format of manifest retrieval timestamp timezones to offests rather than abbreviations so they can be parsed by moment on the front end
|
@mdbenjam Timezoning issues fixed! Timestamps still show the abbreviated timezone, but the timezone offset is also passed up to be parsed by moment for when time calculations are needed. |
mdbenjam
approved these changes
Dec 21, 2018
* Add 'last retrieved' time to warning as well
hschallhorn
added
the
Ready-to-Merge
added 3 commits
December 21, 2018 14:00
va-bot
deleted the
hschallhorn/reader/6049-vbms-vva-download-error-alert
branch
anyakhvost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6049
Description
Added error in the document list for when the was never a response from VBMS or VVA. Added a similar warning for when the last response was older than the eFolder cache limit. Reimplemented retrieval timestamps.