Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Justin/appeals 41645 v1 #21653

Merged
merged 8 commits into from
May 17, 2024
Merged

Conversation

sulak-j
Copy link
Contributor

@sulak-j sulak-j commented May 15, 2024

Resolves Auto-Assign: Mail Superuser capacity calculation

Description

Changed the superuser definitions to calculate based on the "Superuser: Split, Merge, Reassign" permissions.
Added a seed file for test users with the superuser permissions
Updated/Refactored the auto assignable

NOTES:
The users that now meet the new definition of superusers are the following:

  • INBOUND_OPS_TEAM_ADMIN_USER
  • INBOUND_OPS_TEAM_MAIL_INTAKE_USER

Acceptance Criteria

  • Check that the capacity rule for super users is calculating correctly
  • Change the super user definitions to match users with "Superuser: Split, Merge, and Reassign" permissions
  • Verify tests are passing

Testing Plan

  1. Go to Jira Issue/Test Plan Link or list them below

  2. Log in as Jolly Postman and navigate to /queue/correspondence (which can either be appended to the address bar, or you can click "queue" and then choose "your correspondence" from the switch views dropdown). This will show you what the view should look like for a standard user.

  3. Using a new tab, you can navigate to /test/users and sign in to INBOUND_OPS_TEAM_ADMIN_USER (Jon Mailteam Snow Admin).

  4. Once you see the new user is logged in in the top right corner, you can navigate back to the first tab and refresh your page (in the /queue/correspondence tab). This should change the views and open the team view of the correspondence cases.

  5. Since this user is now a superuser, the Auto assign correspondences button should show up and appear blue.

  6. Using the /test/users tab, now log in as INBOUND_OPS_TEAM_MAIL_INTAKE_USER (Jon Mailteam Snow Mail Intake)

  7. Once you see the new user is logged in in the top right corner, you can navigate back to the first tab and navigate to /queue/correspondence. This should again change the views and open the team view of the correspondence cases.

  8. Since this user is also a superuser, the Auto assign correspondences button should show up and appear blue.

@sulak-j sulak-j changed the base branch from master to feature/APPEALS-13579-v1 May 15, 2024 19:02
Copy link

codeclimate bot commented May 15, 2024

Code Climate has analyzed commit 7f40aca and detected 24 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 14
Security 1
Complexity 6
Style 1
Performance 2

View more on Code Climate.

@sulak-j sulak-j marked this pull request as ready for review May 15, 2024 21:51
@sulak-j sulak-j requested a review from HunJerBAH May 15, 2024 21:51
app/models/user.rb Outdated Show resolved Hide resolved
@sulak-j sulak-j requested a review from HunJerBAH May 16, 2024 18:04
Copy link
Contributor

@HunJerBAH HunJerBAH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm and the seed data looks good. Great work Justin!

@HunJerBAH HunJerBAH merged commit 054ac38 into feature/APPEALS-13579-v1 May 17, 2024
14 of 17 checks passed
@HunJerBAH HunJerBAH deleted the Justin/APPEALS-41645-v1 branch May 17, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants