41642 - Intake: task creation #21636

IsaiahBar · 2024-05-14T18:11:16Z

Description

Limit Correspondence Task creation to only users within Inbound Ops Team so that, when reports are created to view all created tasks during intake, it will be only Inbound Ops users who created the tasks

spec/controllers/tasks_controller_spec.rb

app/controllers/correspondence_review_package_controller.rb

app/models/user.rb

db/seeds/correspondence_auto_assign.rb

db/seeds/users.rb

app/models/tasks/correspondence_task.rb

HunJerBAH

Some changes needed to keep plurality and naming consistent from before/after, but otherwise good work!

app/controllers/correspondence_queue_controller.rb

app/views/correspondence/correspondence_team.html.erb

app/views/correspondence/review_package.html.erb

client/app/queue/correspondence/CorrespondenceCases.jsx

client/app/queue/correspondence/correspondenceReducer/correspondenceConstants.js

client/app/queue/correspondence/correspondenceReducer/correspondenceReducer.js

…and removed old checks that are not needed

…or assignment

…rrespondence.scss stylesheet

…ondence_auto_assign.rb

* new branch for inbound_ops_team_user changes * more changes * changes for database * updated changes for InboundOpsTeam * update inbound name * update name * update spec test * remove comma * namespace validation * fixed plurality * change namespace for correspondence verification * fix plurality changes * remove brackets * fixing spec test * update naming * update spec tests... again :) * update affilaited * updated correspondence access check to handle if no user is present, and removed old checks that are not needed * excluded admins from inbound ops team user check * added comment for validation check * added check for system users and allow system users to create correspondence tasks * updated seeds and correspondence validation to check current session user * fixed linting issues * updated factory to sign out system user, removed other org checks from the controller validation, and added back in guard clause for correspondence intake task creation. * reverted mail team change from inbound ops * added saftey operator to system user check * removed factory changes and added validations to correspondence create_from_params methods * moved created methods to self and updated failing test * fixed failing tests * fixed failing correspondence tests * fixed failing tests by adding test user back into MailTeam org * fixed failing test in review package spec by adding back in MailTeam or assignment * updated failing tests and linting issues in tests * fix linting issues in organization users scss * pshing up linting fixes for correspondence.scss * finish lint clean up * fixed test failures * resolved linting issues in stylesheet * resolved failing test in intake spec * resolved failing test * fixed permission check to check current user * fixed styling issue with pagination buttons * removed Jolly Postman from seed data * upped wait time. * updated verify_correspondence_access to accept a user param * fixed linting issues in _correspondence.scss * fixed correspondence_intake_spec test and fixed linting issues on _correspondence.scss stylesheet * fixed method name on inbound ops team seed member creation in correspondence_auto_assign.rb --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

IsaiahBar added 2 commits May 14, 2024 13:55

new branch for inbound_ops_team_user changes

5128411

more changes

f6dd570

HunJerBAH mentioned this pull request May 14, 2024

draft pr updating inbound_ops_team_user #21622

Closed