msteele/APPEALS-45285-v2 Fix delete_conference in PexipService #21634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konhilas-ariana
approved these changes
May 16, 2024
mchbidwell
pushed a commit
that referenced
this pull request
May 20, 2024
* added saftey opperator and removed outdated date check * removed leftover method that was breaking and unused. * removed legacy appeal date check for MST on special issue list * updated mst and pact badges to check decisions in flight (if any) then appeal model. * removed bypass for special issue list for pact toggle for AMA. * updated rake and seed comments * allowed special issues page tracking for AMA MST issues when pact is enabled * remove code changes causing cancel to progress forward * Update scheduled jobs key and move job to different folder * Update job to set user manually and pass in updated_by * moved method definition validate_claim_code into ClaimLabelChange class * fixed spacing issue * msteele/APPEALS-45182 Fix transcription_files relationships on Hearings/LegacyHearings (#21492) * APPEALS-45182 Reinforce has_many relationships * APPEALS-45182 Add missing comma * Resolve lint issue --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * fixed linting error * fixed linting issue * draft pr * Hotfix/APPEALS-45218 (#21503) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-25218 Update WebexService to remove config in favor of individual arguments * APPEALS-45218 Format comment --------- Co-authored-by: msteele <Marc.Steele@va.gov> * Wmedders21/appeals 44873 (#21469) * add rubyzip gem * Test: Hearings::ZipAndUploadTranscriptionFilesJob * Feature: Hearings::ZipAndUploadTranscriptionFilesJob * Add zip subfolder to tmp/transcription_files * Move new gem to proper alphabetical position in list * revert gem file changes * update gem file with feature branch * refactor #perform method parameters * update parameter name * Piedram/appeals 44897 (#21519) * Create new Workflow transcription_packages: Step One * add some changes * Modified the parameters for ZipAndUploadTranscriptionFilesJob * Modified spec test * Update transcription_packages.rb * remove extra blank line --------- Co-authored-by: piedram <maite.piedrayera@va.gov> * Wmedders21/appeals 44874 (#21512) * add rubyzip gem * Test: Hearings::ZipAndUploadTranscriptionFilesJob * Feature: Hearings::ZipAndUploadTranscriptionFilesJob * Add zip subfolder to tmp/transcription_files * Move new gem to proper alphabetical position in list * revert gem file changes * update gem file with feature branch * refactor #perform method parameters * update parameter name * add zip extension to valid file types * Test: transcription file creation and upload to s3 * Hearings::ZipAndUploadTranscriptionFilesJob updates db and uploads to s3 * resolve merge conflict * APPEALS-44876 Work order job file (#21504) * APPEALS-44876 Work order job file * Updated filename with work order name * Refactored create table method and updated spec --------- Co-authored-by: Jim Foley <james.foley4@va.gov> * Completing AC for ticketing for styling and error portion of page. Now doing feature test * B_reed/hotfix_APPEALS-45285 (#21531) * APPEALS-45285 Bug Fix * APPEALS-45285 update pexip_service_spec * APPEALS-45285 remove white space * Hotfix/APPEALS-45218-v2 (#21522) * APPEALS-45218 reverted webex config arguments * APPEALS-45218 reverted webex config arguments * APPEALS-45218 added query argument to webex conference link * APPEALS-45218: webex recordings endpoint correction * APPEALS-45218 adjusted arguments during inititalizing of refresh tokens * APPEALS-45218 fixed rspec * APPEALS-45218: added error catching on webex service response * APPEALS-45218: remove tested code * APPEALS-45218 Go back to leveraging HTTPI response inherited methods --------- Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: msteele <Marc.Steele@va.gov> * added ability for user to search by css id * added feature tests for using search bar * reverted changes in package.json * removed added file * removed linting error * msteele/APPEALS-45349 (#21539) * APPEALS-45349 Check for error on HTTPI object, then create Webex response object and fail with specific error * APPEALS-45349 Flip conditionals * APPEALS-45349 Fix linting errors * searchable by 2 characters instead of 1 * hotfix/APPEALS-45399-45401-45472 (#21555) * APPEALS-45399-45401 Update fetch webex list and details to retrieve apikey from cred stash * APPEALS-45399-45401 Remove CGI escape from fetch webex list job * APPEALS-445399-45401 Update spec files for webex list and details job * APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery * Revert "APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery" This reverts commit d9ce585. * ccc * gggg * gggg * Create new Workflow transcription_packages: Step Two (#21570) * Add call function to the new job, and modified spec files * call the jobs * feature/APPEALS-44188-44282 - Deprecation fixes for Rails 6.1 (release) (#21614) * 🔀 Squash merge jcroteau/APPEALS-44188-fix-deprecation-warning-class-level-methods-will-no-longer-inherit-scoping * 🔀 Squash merge jcroteau/APPEALS-44282-fix-deprecation-not-conditions-will-no-longer-behave-as-nor * Work order file upload to AWS s3 (#21582) * Work order file upload to AWS s3 * refactor code for upload to AWS * refactor code for instance variables * Revert "refactor code for instance variables" This reverts commit b61c72a. * code refactor for work order file * APPEALS-44877 refactor for work order * APPEALS-44310: add notification for unexpected task trees and update tests (#21474) * add notification for unexpected task trees and update tests * add slack notification to distribution errors, set default slack url in SlackService * add tests for distributions to validate handling of errors in the ama_statistics method * fix bad check for allowable tasks * fix tests which were expecting a url as arg to new slack service * fix codeclimate warning * APPEALS-45199: Update Quality Review selection probabilities #21518 * APPEALS-44423: Remove therubyracer and jshint gems (#21443) * APPEALS-42941 copied over Matt's work (#21624) * APPEALS-43190 (#21448) * APPEALS-43190 initial migration file * APPEALS-43190 add seed data * APPEALS-43190 add magic comment * APPEALS-43190 move seed command * APPEALS-43190 add bang! * APPEALS-43190 update migration file * APPEALS-43190 attribute name fix and updates * APPEALS-43190 fix seed attribute * APPEALS-43190 stubbed more seed data * APPEALS-43190 remove seed comment * APPEALS-43190 remove comment * APPEALS-43190 add magic comment * APPEALS-43190 update comments * Wmedders21/appeals 44875 (#21605) * Add retry logic for upload failure * fix indentation rubocop warning * Refactor zip job * remove blank line --------- Co-authored-by: Jim Foley <james.foley4@va.gov> * akonhilas/APPEALS-43193 (#21581) * APPEALS-43193: Add new columns and indexes to transcriptions table * APPEALS-43193: Add new columns and indexes to transcriptions table * APPEALS-43193: move index to own file * APPEALS-43193: Update transcription contractor id to bigint * APPEALS-43193: bigint * APPEALS-43193: add fk after trancription_contractors table added * lint error resolution (#21631) * hotfix/APPEALS-45472 (#21562) * APPEALS-45472 Refactor error handling for transcription * APPEALS-45472 Include missing provider in error details for fetch recording list job and update comment for mailer * Hotfix/APPEALS-45818 (#21632) * APPEALS-45818: parsing fix, remove topic param, fix response * APPEALS-45818: revert list and details job back to original state, update tests --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * APPEALS-44878 refactor for retry and upon success kickoff zip file job (#21652) * APPEALS-44878 refactor for retry and upon success kickoff zip file job * APPEALS-44878 refactor code * APPEALS-44878 refactor xls path * lint error fix * msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634) * APPEALS-45285 update ExternalApi::PexipService#delete_conference to accept virtual_hearing as the only argument * APPEALS-45285 Update spec to use virtual_hearing * APPEALS-45285 Linting fixes * Piedram/appeals 45696 (#21655) * Create new Workflow Error handling transcription_packages: Step Three related to appeals-31793 * MOdified spec file * fix lint error * APPEALS-45696 refactor for work_order_params --------- Co-authored-by: Kamala Madamanchi <kamala.madamanchi@va.gov> Co-authored-by: Jim Foley <james.foley4@va.gov> * hotfix/APPEALS-45828 (#21625) * APPEALS-45828 Include call to create webex conference links in base hearing update form * APPEALS-45828 Update details feature spec to expect webex link creation on conversion from virtual * Fix needing to reload to display co host link on details page * Fix incorrect method name * Remove temporary rendering of default pexip link for webex hearings after conversion * APPEALS-45828 Fix hearing mailer spec context issues and null check for BAD_VIRTUAL_LINK_TEXT * APPEALS-45828 Remove file name argument from fetch details job spec * APPEALS-45828 Fail on bad hearing link if link nil or legacy link * APPEALS-45828 Sanitize url string * APPEALS-45828 Undo url sanitize * Remove unused styles after merge * Fix lint warnings --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Andrew Hadley <hadley_andrew@bah.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: IsaiahBar <isaiah.barnett@va.gov> Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com> Co-authored-by: Will Medders <93014155+wmedders21@users.noreply.github.com> Co-authored-by: Jim Foley <james.foley4@va.gov> Co-authored-by: piedram <maite.piedrayera@va.gov> Co-authored-by: Kamala Madamanchi <110078646+kamala-07@users.noreply.github.com> Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: raymond-hughes <raymond.hughes2@va.gov> Co-authored-by: Jeff Marks <106996298+jefftmarks@users.noreply.github.com> Co-authored-by: piedram <110848569+piedram@users.noreply.github.com> Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com> Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> Co-authored-by: Amy Detwiler <133032208+amybids@users.noreply.github.com> Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com> Co-authored-by: mikefinneran <110622959+mikefinneran@users.noreply.github.com> Co-authored-by: Kamala Madamanchi <kamala.madamanchi@va.gov>
minhazur9
added a commit
that referenced
this pull request
May 23, 2024
…-affairs/caseflow into min/APPEALS-43140 * 'min/APPEALS-43140' of github.com:department-of-veterans-affairs/caseflow: (57 commits) APPEALS-45503 created table for transcription_packages (#21685) Wmedders21/appeals 43231 (#21670) Remove unused styles after merge hotfix/APPEALS-45828 (#21625) Piedram/appeals 45696 (#21655) msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634) APPEALS-44878 refactor for retry and upon success kickoff zip file job (#21652) Hotfix/APPEALS-45818 (#21632) hotfix/APPEALS-45472 (#21562) lint error resolution (#21631) APPEALS-42941 copied over Matt's work (#21624) APPEALS-44423: Remove therubyracer and jshint gems (#21443) APPEALS-45199: Update Quality Review selection probabilities #21518 APPEALS-44310: add notification for unexpected task trees and update tests (#21474) feature/APPEALS-44188-44282 - Deprecation fixes for Rails 6.1 (release) (#21614) Added a customizable per page task limitation attribute to QueueTab that is used by task_pager to allow an adjustable maximum number of tasks per tab. (#21594) gggg gggg ccc hotfix/APPEALS-45399-45401-45472 (#21555) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves APPEALS-45285
Description
Update the delete_conference method in ExternalApi::PexipService to fix an ArgumentError that caused this bug fix to fail validation
Acceptance Criteria
Testing Plan