-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calvin/APPEALS-44957-rake-affinity #21577
Merged
craigrva
merged 23 commits into
feature/APPEALS-44916
from
Calvin/APPEALS-44957-rake-affinity
May 17, 2024
Merged
Calvin/APPEALS-44957-rake-affinity #21577
craigrva
merged 23 commits into
feature/APPEALS-44916
from
Calvin/APPEALS-44957-rake-affinity
May 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvincostaBAH
changed the title
grabbed receipt dates from distributed cases
Calvin/APPEALS-44957-rake-affinity
May 9, 2024
craigrva
requested changes
May 14, 2024
craigrva
requested changes
May 15, 2024
craigrva
previously approved these changes
May 15, 2024
craigrva
previously approved these changes
May 16, 2024
craigrva
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves APPEALS-44957
Description
As a developer I need to add a Rake task to “seed” the initial affinity_start_date in all environments, including updating existing local/demo seed data, so that affinity day counters begin the hold period accurately based on the distribution of matching appeals, ensuring timely distribution to the affinitized judge.
-Added rake task to seed affinity_start_date for all ready to distribute appeals with a correlating type, priority, and receipt date to the most recently distributed appeal.
-Added rspec test for rake task
Acceptance Criteria
When the Rake task is executed, it retrieves the receipt_date for the most recent distributed appeals for each of the following docket types and priority statuses:
Using the receipt_date obtained, the Rake task identifies all ready-to-distribute appeals of each corresponding type and priority status (priority or non-priority) with an affinity_start_date equal to or older than the retrieved receipt_date, or with no appeal_affinity record.
The Rake task creates or updates the affinity_start_date records for the identified appeals, ensuring they align with the receipt_date of the most recent distributed appeals of their respective type and priority status.
The Rake task completes successfully without errors and can be executed in all environments
Testing Plan
Frontend
User Facing Changes
Storybook Story
For Frontend (Presentation) Components
MyComponent.stories.js
alongsideMyComponent.jsx
)Backend
Database Changes
Only for Schema Changes
created_at
,updated_at
) for new tablesCaseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)make check-fks
; add any missing foreign keys or add toconfig/initializers/immigrant.rb
(see Record associations and Foreign Keys)belongs_to
for associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling