fix: getRelativeRepoPath for the case of vault-inside-repo #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vinzent03
requested changes
May 25, 2024
| if (this.plugin.settings.basePath.length > 0) { | ||
| return path.substring(this.plugin.settings.basePath.length + 1); | ||
| let adapter = this.plugin.app.vault.adapter; | ||
| if (adapter instanceof FileSystemAdapter) { |
There was a problem hiding this comment.
On mobile, this method does nothing now. I think we should fall back to the old implementation on mobile.
src/gitManager/gitManager.ts
Outdated
| import ObsidianGit from "../main"; | ||
| import { relative, join } from 'path'; |
There was a problem hiding this comment.
please import path with as path here to make the usage from the path library more clearly.
There was a problem hiding this comment.
Does it mean import * as path from 'path'; ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #660.
Currently,
getRelativeRepoPathconsiders only the case of git repository is located inside the vault.If the vault is inside a subdirectory of git repository (this is a common case when you are using a self-host publishing system like Quartz), line authoring feature won't work.
This code resolves the relative path between git repo and vault using
pathlibrary.