Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): resolve push hanging #687

Closed
wants to merge 1 commit into from
Closed

Conversation

ras0q
Copy link

@ras0q ras0q commented Jan 29, 2024

ref: #609 #574

async push() for mobile is implemented using this.branchInfo(), but this branch info should be converted to latest commit hash.

@Vinzent03
Copy link
Collaborator

Did you encounter one of these two branches being null? I'm pretty sure the ref for a Tree can also just be the branch name.

@ras0q
Copy link
Author

ras0q commented Feb 1, 2024

I don't encounter that and using both the branch name and the commit hash can be the ref for a tree.
However by using the commit hash, I think git.TREE({ ref }) can be resolved more quickly.
https://github.com/isomorphic-git/isomorphic-git/blob/53310498e9dd84a213197de2d69047ce733580e6/src/managers/GitRefManager.js#L193

@ras0q
Copy link
Author

ras0q commented Feb 1, 2024

Here is my brief benchmark!
https://github.com/ras0q/isomorphic-git-walk-test

@ras0q
Copy link
Author

ras0q commented Feb 13, 2024

@denolehov @Vinzent03 could you review this PR? Thanks!

@antgiant
Copy link

Adding #653 as another instance.

I’m experiencing this too

@Vinzent03
Copy link
Collaborator

When digging the code of TREE() it uses `resolveRef()', just like you do now manually. I don't see what this pr actually changes.

@Vinzent03 Vinzent03 closed this May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants