chore(bytes): release bytes@1.0.0
#4746
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4746 +/- ##
=======================================
Coverage 91.89% 91.89%
=======================================
Files 484 484
Lines 41296 41296
Branches 5319 5319
=======================================
Hits 37947 37947
Misses 3292 3292
Partials 57 57 ☔ View full report in Codecov by Sentry. |
|
Do we need this PR at this point? How about getting feedback in #4629? |
|
A PR that stabilizes the package is far more obvious and likely to receive feedback. It's a little ugly to have PRs open for so long, but doing so hopefully increases our chances of an issue being pointed out before stabilization. |
dsherret
reviewed
May 17, 2024
There was a problem hiding this comment.
It looks like indexOfNeedle with a negative start value is not tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged on June 7.
Feedback from all is welcome before this package is stabilized.
Closes #4629