Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bytes): release bytes@1.0.0-rc.2 #4745

Merged
merged 1 commit into from
May 16, 2024
Merged

chore(bytes): release bytes@1.0.0-rc.2 #4745

merged 1 commit into from
May 16, 2024

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented May 16, 2024

Mainly for the docs changes.

@iuioiua iuioiua requested a review from kt3k as a code owner May 16, 2024 00:28
@github-actions github-actions bot added the bytes label May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.89%. Comparing base (aa35b35) to head (f122e5f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4745   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files         484      484           
  Lines       41296    41296           
  Branches     5319     5319           
=======================================
  Hits        37947    37947           
  Misses       3292     3292           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua
Copy link
Collaborator Author

iuioiua commented May 16, 2024

Maybe we should add a new PR title type release just for releases.

@kt3k
Copy link
Member

kt3k commented May 16, 2024

In my opinion version bump should be tagged with chore:. This doesn't add any new feature

@kt3k
Copy link
Member

kt3k commented May 16, 2024

BTW this version upgrade will automatically happen by https://jsr.io/@deno/bump-workspaces in the next release flow. Any change in prerelease version package causes the increment of the last fragment of prerelease id. (Manual upgrade also works though)

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua changed the title feat(bytes): bytes@1.0.0-rc.2 chore(bytes): release bytes@1.0.0-rc.2 May 16, 2024
@iuioiua
Copy link
Collaborator Author

iuioiua commented May 16, 2024

True - this doesn't add any feature. Changed it to chore and will do for releases from now on.

@iuioiua iuioiua merged commit cc63704 into main May 16, 2024
13 checks passed
@iuioiua iuioiua deleted the bytes-rc-2 branch May 16, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants