feat(net): getNetworkAddress()
#4677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4677 +/- ##
==========================================
+ Coverage 91.95% 91.97% +0.02%
==========================================
Files 487 488 +1
Lines 38894 38899 +5
Branches 5388 5392 +4
==========================================
+ Hits 35766 35779 +13
+ Misses 3072 3064 -8
Partials 56 56 ☔ View full report in Codecov by Sentry. |
kt3k
reviewed
May 7, 2024
kt3k
reviewed
May 9, 2024
kt3k
reviewed
May 12, 2024
|
Sorry, my understanding of some of the IPv6 addressing was incorrect. Corrected now, and scope ID isn't needed. |
Why is the check of scopeid unnecessary?
|
* fix(net): check scopeid === 0 * tweaks * tweak --------- Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like a useful tool to have.