Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BREAKING): flip keep_comments to remove_comments #246

Merged
merged 2 commits into from
May 30, 2024

Conversation

dsherret
Copy link
Member

People check for comments in .toString() so we need to keep the comments by default.

@dsherret dsherret requested a review from bartlomieju May 14, 2024 21:06
@dsherret
Copy link
Member Author

Will merge this later when doing more breaking changes in this repo.

@dsherret dsherret merged commit 7b6757d into denoland:main May 30, 2024
2 checks passed
@dsherret dsherret deleted the revert_remove_comments branch May 30, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants