[WIP] upgrade: tokio 0.3 #7988
Closed
[WIP] upgrade: tokio 0.3 #7988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a1phyr
reviewed
Oct 20, 2020
| @@ -133,7 +133,7 @@ async fn post_message_and_poll( | |||
| // A zero delay is long enough to yield the thread in order to prevent the loop from | |||
| // running hot for messages that are taking longer to resolve like for example an | |||
| // evaluation of top level await. | |||
| tokio::time::delay_for(tokio::time::Duration::from_millis(0)).await; | |||
| tokio::time::sleep(tokio::time::Duration::from_millis(0)).await; | |||
There was a problem hiding this comment.
Unrelated to tokio 0.3 upgrade, but I think using tokio::task::yield_now would be better here.
There was a problem hiding this comment.
As far as I remember I tried that early on and it spun hot at 100% but I'll take a look at it again now.
There was a problem hiding this comment.
Yeah it'll turn hot 😕
|
We need to do a lot of refactors before migration to Tokio 0.3 becomes feasible. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7984