Refactor snapshot build #2825
Merged
Refactor snapshot build #2825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
changed the title
ry
force-pushed
the
deno_typescript
branch
2 times, most recently
from
c92e9a2
to
473c07f
Compare
Instead of using core/snapshot_creator.rs, instead two crates are introduced which allow building the snapshot during build.rs. Rollup is removed and replaced with our own bundler. This removes the Node build dependency. Modules in //js now use Deno-style imports with file extensions, rather than Node style extensionless imports. This improve incremental build time when changes are made //js files by about 40 seconds.
3 tasks
ry
commented
Aug 31, 2019
| if !build.check_only { | ||
| build.run("cli:deno_deps"); | ||
| } | ||
| } |
There was a problem hiding this comment.
Note that cli/build.rs is removed. That means it does not depend on GN during "cargo build"
ry
commented
Aug 31, 2019
| deps = [ | ||
| ":compiler_bundle", | ||
| ] | ||
| } |
There was a problem hiding this comment.
Note existing snapshot infrastructure is removed.
ry
commented
Aug 31, 2019
| @@ -1,231 +0,0 @@ | |||
| // Copyright 2018-2019 the Deno authors. All rights reserved. MIT license. | |||
piscisaureus
reviewed
Sep 2, 2019
piscisaureus
reviewed
Sep 2, 2019
piscisaureus
reviewed
Sep 2, 2019
piscisaureus
reviewed
Sep 2, 2019
piscisaureus
reviewed
Sep 2, 2019
piscisaureus
reviewed
Sep 2, 2019
piscisaureus
reviewed
Sep 2, 2019
piscisaureus
reviewed
Sep 2, 2019
piscisaureus
reviewed
Sep 2, 2019
piscisaureus
reviewed
Sep 2, 2019
piscisaureus
reviewed
Sep 2, 2019
piscisaureus
reviewed
Sep 2, 2019
piscisaureus
reviewed
Sep 2, 2019
piscisaureus
reviewed
Sep 2, 2019
piscisaureus
reviewed
Sep 2, 2019
piscisaureus
reviewed
Sep 2, 2019
piscisaureus
reviewed
Sep 2, 2019
piscisaureus
reviewed
Sep 2, 2019
piscisaureus
reviewed
Sep 2, 2019
|
This patch reduced executable size by 7mb. It had some effect on some of the benchmark's memory usage as well.
|
hexagon6
reviewed
Sep 2, 2019
| @@ -18,9 +18,9 @@ export interface BuildInfo { | |||
| export const build: BuildInfo = { | |||
| // These string will be replaced by rollup | |||
There was a problem hiding this comment.
comment about rollup will be outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2827
Fixes #2496
Fixes #2711
Fixes #459
Towards #2608
Towards #986
Prototype: https://github.com/ry/deno_typescript
This patch removes the build dependency on Node and rollup and consequently deletes approximately 1 million lines from third_party/node_modules.
A Rust Crate was published with public V8 snapshotting API https://crates.io/crates/deno_typescript