Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix flaky rejection_handled_web_process #23817

Merged
merged 2 commits into from
May 14, 2024
Merged

chore: fix flaky rejection_handled_web_process #23817

merged 2 commits into from
May 14, 2024

Conversation

dsherret
Copy link
Member

Closes #23712

@dsherret dsherret requested a review from bartlomieju May 14, 2024 23:14
@dsherret dsherret enabled auto-merge (squash) May 14, 2024 23:16
bartlomieju
bartlomieju approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this fixes the underlying problem, but let's try it. Thanks for migrating it to a spec test

@dsherret dsherret merged commit 1a788b5 into denoland:main May 14, 2024
17 checks passed
bartlomieju pushed a commit that referenced this pull request May 16, 2024
@dsherret @bartlomieju
chore: fix flaky rejection_handled_web_process (#23817)
b68e0cd 
Closes #23712
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rejection_handled_web_process is flaky
2 participants
@dsherret @bartlomieju