Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle specifying an import map in an ancestor dir of deno.json #23602

Merged
merged 4 commits into from Apr 29, 2024
Merged

fix: handle specifying an import map in an ancestor dir of deno.json #23602

merged 4 commits into from Apr 29, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Apr 29, 2024 •
edited

@dsherret dsherret marked this pull request as ready for review April 29, 2024 15:30
bartlomieju
bartlomieju approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch

@dsherret dsherret merged commit 4384a12 into denoland:main Apr 29, 2024
17 checks passed
@dsherret dsherret deleted the fix_regression_import_map_parent branch April 29, 2024 18:32
@dsherret dsherret mentioned this pull request May 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Relative import path not prefixed
2 participants
@dsherret @bartlomieju