Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(unstable): --unstable-unsafe-proto #21313

Merged
merged 3 commits into from
Nov 25, 2023
Merged

feat(unstable): --unstable-unsafe-proto #21313

merged 3 commits into from
Nov 25, 2023

Conversation

dsherret
Copy link
Member

Closes #21276

bartlomieju
bartlomieju approved these changes Nov 25, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you think we should somehow modify error messages when one tries to access __proto__ to suggest this flag?

kt3k
kt3k approved these changes Nov 25, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also in favor of having this. Some legacy npm modules (ex. acorn-node, old version of chalk) depend on this feature, and there's no (reliable) workaround when such modules are in dependencies.

@dsherret
Copy link
Member Author

Do you think we should somehow modify error messages when one tries to access proto to suggest this flag?

Probably #16775 would help with that, but I'm not sure there's any way to do this reliably with an error.

@dsherret dsherret merged commit a4ec7df into denoland:main Nov 25, 2023
14 checks passed
@dsherret dsherret deleted the unstable_unsafe_proto branch November 25, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider --unstable-unsafe-proto flag
3 participants
@dsherret @kt3k @bartlomieju