Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(npm): allow to inspect npm modules with --inspect-brk #16841

Merged
merged 8 commits into from
Nov 28, 2022
Merged

fix(npm): allow to inspect npm modules with --inspect-brk #16841

merged 8 commits into from
Nov 28, 2022

Conversation

bartlomieju
Copy link
Member

Closes #16757

bartlomieju
bartlomieju commented Nov 27, 2022
View reviewed changes
runtime/worker.rs Outdated Show resolved Hide resolved
runtime/web_worker.rs Outdated Show resolved Hide resolved
runtime/worker.rs Outdated Show resolved Hide resolved
@bartlomieju bartlomieju changed the title fix(inspector): allow to inspect npm modules fix(npm): allow to inspect npm modules with --inspect-brk Nov 28, 2022
dsherret
dsherret approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

runtime/worker.rs Outdated Show resolved Hide resolved
runtime/web_worker.rs Outdated Show resolved Hide resolved
@bartlomieju bartlomieju merged commit fd51b2e into denoland:main Nov 28, 2022
@bartlomieju bartlomieju deleted the inspect_cjs_modules branch November 28, 2022 21:00
kt3k pushed a commit that referenced this pull request Dec 1, 2022
@bartlomieju @kt3k
fix(npm): allow to inspect npm modules with --inspect-brk (#16841)
cccc95a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--inspect-brk doesn't stop execution when running global npm commands
2 participants
@bartlomieju @dsherret