fix(extension/file): update File constructor following the spec #10760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacasonato
approved these changes
May 25, 2021
piscisaureus
pushed a commit
that referenced
this pull request
May 31, 2021
piscisaureus
pushed a commit
that referenced
this pull request
May 31, 2021
piscisaureus
pushed a commit
that referenced
this pull request
May 31, 2021
piscisaureus
pushed a commit
that referenced
this pull request
May 31, 2021
piscisaureus
pushed a commit
that referenced
this pull request
May 31, 2021
piscisaureus
pushed a commit
that referenced
this pull request
May 31, 2021
|
The introduction of the document.body polyfill has broken significant amounts of the internals of testharness.js (mainly through this function: https://github.com/web-platform-tests/wpt/blob/master/resources/testharness.js#L471). The tests that this PR looks to make pass, are actually failing, the polyfill is just hiding it. I am going to revert the polyfill. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a retry of #10459. (This time it doesn't depends on the harness issue)
This PR updates the File constructor, following this spec update w3c/FileAPI#171. This PR removes the file name replacement, and enables the corresponding wpt by polyfilling the global
document.bodyobject. This PR also updates the wpt expectations which start passing because of the document.body polyfill.