Skip to content

Commit

Permalink
fix(node): stub AsyncResource.emitDestroy() (#23802)
Browse files Browse the repository at this point in the history
<!--
Before submitting a PR, please read
https://docs.deno.com/runtime/manual/references/contributing

1. Give the PR a descriptive title.

  Examples of good title:
    - fix(std/http): Fix race condition in server
    - docs(console): Update docstrings
    - feat(doc): Handle nested reexports

  Examples of bad title:
    - fix #7123
    - update docs
    - fix bugs

2. Ensure there is a related issue and it is referenced in the PR text.
3. Ensure there are tests that cover the changes.
4. Ensure `cargo test` passes.
5. Ensure `./tools/format.js` passes without changing files.
6. Ensure `./tools/lint.js` passes.
7. Open as a draft PR if your work is still in progress. The CI won't
run
   all steps, but you can add '[ci]' to a commit message to force it to.
8. If you would like to run the benchmarks on the CI, add the 'ci-bench'
label.
-->

Fixes #23397
  • Loading branch information
marvinhagemeister committed May 14, 2024
1 parent 3b51ea7 commit e389917
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
2 changes: 2 additions & 0 deletions ext/node/polyfills/async_hooks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,8 @@ export class AsyncResource {
}
}

emitDestroy() {}

bind(fn: (...args: unknown[]) => unknown, thisArg = this) {
validateFunction(fn, "fn");
const frame = AsyncContextFrame.current();
Expand Down
5 changes: 5 additions & 0 deletions tests/unit_node/async_hooks_test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -130,3 +130,8 @@ Deno.test(function asyncResourceStub() {
const resource = new AsyncResource("dbquery");
assert(typeof resource.asyncId() === "number");
});

Deno.test(function emitDestroyStub() {
const resource = new AsyncResource("foo");
assert(typeof resource.emitDestroy === "function");
});

0 comments on commit e389917

Please sign in to comment.