Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump go-libp2p version to v0.17.0 to add hole punching support #19

Closed
wants to merge 8 commits into from

Conversation

optman
Copy link

@optman optman commented Feb 17, 2022

mdns compiled but not works, no idea why.

@dennis-tra
Copy link
Owner

Awesome! Thanks a lot for the PR! Not sure if you read it, but this comes right in time as we were just discussing this in #18!

Unfortunately, I will only have time to take a look at it next week, but this will most likely land in here :)

@optman
Copy link
Author

optman commented Feb 18, 2022

Good to known that. And then you could check the mdns issue also :)

@decentral1se
Copy link

Amazing! Was just wondering if pcp would be supporting the new hole punching work. Super cool.

@dennis-tra
Copy link
Owner

@optman I filed a PR against your PR with a fix for the mDNS discovery. However, the decentralized hole punching documentation suggests a more involved connection handling than currently implemented. I have the chance to chat with some libp2p devs in a couple of weeks and will bring that up then.

@megapro17
Copy link

can you upload compiled windows binary?

@optman optman closed this Mar 10, 2022
@dennis-tra
Copy link
Owner

Feel free to keep this PR open. Just yesterday I had the chance to catch up with some of the devs and he mentioned the missing option:

libp2p.EnableAutoRelay(autorelay.WithDefaultStaticRelays()),

I'll test this branch with the above additional option and would leave feedback here or make changes right away.

@optman
Copy link
Author

optman commented Mar 10, 2022

I just notice the PR is on based on the wrong branch, it contains many unrelated commits. Anyway, you have merged the code on distributed-hole-punching branch.

I don't think WithDefaultStaticRelays would be any help, it is only there to quicken relay establish.

https://github.com/libp2p/go-libp2p/blob/f0db9cc407a2982faa5a04563ad5fc48326932ce/p2p/host/autorelay/autorelay.go#L173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants