Bug fix: Mark connection as not good when error on cancellation confirmation #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #773 +/- ##
==========================================
+ Coverage 71.35% 71.38% +0.02%
==========================================
Files 24 24
Lines 5405 5407 +2
==========================================
+ Hits 3857 3860 +3
+ Misses 1303 1302 -1
Partials 245 245
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zcolleen
force-pushed
the
master
branch
3 times, most recently
from
a0bfc23
to
be6a6fc
Compare
added 2 commits
November 9, 2022 18:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes bug when we were not able to get cancelation confirmation but connection is not marked as bad and returns to pool, so next time this connection is taken from pool, we get the same error instead of opening new good connection
Example:
r, err := db.QueryContext(ctx, query) <- context expired, then we got cancelation confirmation error
...
r, err := db.QueryContext(ctx, query) <- we get same error because we are still using bad connection instead of opening new one