Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to azidentity 0.13.1 #722

Closed
wants to merge 2 commits into from
Closed

update to azidentity 0.13.1 #722

wants to merge 2 commits into from

Conversation

gambtho
Copy link

@gambtho gambtho commented Feb 27, 2022

adds support for using azidentity with resourceID - #721

@codecov
Copy link

codecov bot commented Feb 27, 2022

Codecov Report

Merging #722 (1128756) into master (e538731) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #722      +/-   ##
==========================================
- Coverage   71.29%   71.24%   -0.06%     
==========================================
  Files          24       24              
  Lines        5386     5386              
==========================================
- Hits         3840     3837       -3     
- Misses       1301     1303       +2     
- Partials      245      246       +1     
Impacted Files Coverage Δ
tds.go 65.49% <0.00%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e538731...1128756. Read the comment docs.

@gambtho
Copy link
Author

gambtho commented Feb 27, 2022

codecov changes don't appear related to the files I changed

azuread/configuration.go Show resolved Hide resolved
azuread/configuration.go Outdated Show resolved Hide resolved
azuread/configuration.go Show resolved Hide resolved
README.md Show resolved Hide resolved
@gambtho
Copy link
Author

gambtho commented Mar 1, 2022

@kardianos would you mind to review this also? it's an update of #698 which you approved in Jan

@shueybubbles
Copy link
Contributor

you could clone the issue and the PR in github.com/microsoft/go-mssqldb
Our fork is live now.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants