Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connection logging to help with debugging #626

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wrosenuance
Copy link
Contributor

While debugging connection problems it can be helpful to look at the TDS traffic, ideally the unencrypted traffic if encryption is enabled. This patch adds a connection logger that emits the encrypted and unencrypted packets as a hex dump, and also supports the TLS_LOG_KEY_FILE needed for TLS interception in tools like Wireshark.

Split out of #547 where it was first used/relevant.

@wrosenuance
Copy link
Contributor Author

Hi @kardianos, this is the second piece of #547 - a self-contained patch around adding in connection logging.

@kardianos
Copy link
Collaborator

Great to see it, but I want to wait until the first one is settled a bit more.

@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #626 (768b5e3) into master (045585d) will decrease coverage by 0.05%.
The diff coverage is 78.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #626      +/-   ##
==========================================
- Coverage   71.98%   71.92%   -0.06%     
==========================================
  Files          24       25       +1     
  Lines        5469     5529      +60     
==========================================
+ Hits         3937     3977      +40     
- Misses       1309     1322      +13     
- Partials      223      230       +7     
Impacted Files Coverage Δ
conn_str.go 99.18% <25.00%> (-0.82%) ⬇️
tds.go 66.54% <33.33%> (-1.06%) ⬇️
log_conn.go 100.00% <100.00%> (ø)
token.go 60.28% <0.00%> (-0.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 045585d...768b5e3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants