Fixed issues with TVPs #622
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you write the any test? I don't understand your fix |
|
Ah, my apologies. I dug into the code a little more and discovered that I hadn't implemented the changes correctly. Essentially, these are supposed to support conversion of a slice of pointers to a TPV and to ignore unexported fields when converting TPV data to SQL data. |
|
This change alters renames a number of existing fields. Please revert. Please also document what type of values this accepts, include in comments with examples of what this solves. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two recently uploaded issues wherein TVP checking will fail if the value was a slice of pointers and where TVP will not ignore internal fields.