WIP: Allow the customization of the TLS connection #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 17, 2020
denisenkom
reviewed
Nov 3, 2020
| tlsConn := tls.Client(&passthrough, &config) | ||
| var tlsConn *tls.Conn | ||
| if c.NewTLSConn != nil { | ||
| // TODO modify NewTLSConn to also return an err? and bail if err? |
There was a problem hiding this comment.
I think it is better to have NewTLSConn to have same interface as tls.Client, so current implementation should be ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #308 and #444.
I'm using this at https://github.com/rgl/dump-sql-server-certificate-chain/tree/configure-tls
Can you please review? I've got several TODOs in there that I'm not sure how to implement this.