Enable consumption into secretless-broker #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ming the project - Consts - Prelogin consts (PreloginVERSION, PreloginENCRYPTION, etc.) - Encrypt consts (EncryptOff, EncryptOn, etc.) - Types - TdsBuffer - KeySlice - Functions - NewTdsBuffer - ReadNextPacket
Codecov Report
@@ Coverage Diff @@
## master #533 +/- ##
==========================================
- Coverage 68.86% 68.83% -0.03%
==========================================
Files 22 22
Lines 5058 5060 +2
==========================================
Hits 3483 3483
- Misses 1369 1371 +2
Partials 206 206
Continue to review full report at Codecov.
|
|
I don't like exposing so much of internal structures as an interface. That would make it much harder to change internals without introducing a breaking change in the interface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are adding a plugin to the
secretless-brokerproject (https://github.com/cyberark/secretless-broker) and will be using your project to communicate with SQL Server. Secretless is written ingotoo and needs a bit more access to some of the internals of this project. In this PR we expose the constants & functions we need to use. Other than that, the logic stays the same.The Secretless Broker lets your applications connect securely to services - without ever having to fetch or manage passwords or keys. It does so by acting as a connector between the application and the target, retrieving the credentials for authentication from a credentials provider. This way, it opens an authenticated stream between the application and the target, so the application doesn't need to manage credentials in its code. To do so with mssql, we need to get the underlying channel and and the credentials to the message. We needed access to some constants and structs to do so.
It would be great if these minor changes will be merged to the
go-mssqldbproject so we can consume it as a 3rd party to our project, rather than relying on our own fork.