fix(refs T31010): Handle ES5/ES6 issues #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is some issue with the global accessibility from within the template.
| @@ -55,6 +56,9 @@ const config = { | |||
| plugins: [ | |||
| new MiniCssExtractPlugin(), | |||
| new VueLoaderPlugin(), | |||
| new DefinePlugin({ | |||
There was a problem hiding this comment.
I do not understand what is achieved by DefinePlugin here.
There was a problem hiding this comment.
Me neither. I hoped You got an Idea. It seems to fix the issue, but why - I can't say. :-/
# Conflicts: # src/components/core/DpEditor/DpResizableImage.vue
|
This was the wrong track |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some Pages we found strange behavior resolving some external Dependencies. We thought, they where already fixed by transpiling them during the buildstep, but it turned out that it wasn't enough.
here webpack/webpack#2933 I found another solution on top, which I applied and which looks like it works.
You can test this in demosplan-core -> /einstellungen/plattform (as Support)
ATM there are still changes to make it localy testable.
(changes in package.json)
refs https://yaits.demos-deutschland.de/T31010