re-add migration and add tests for it & update core to 1.139.3 #3831
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revealed some crash issues on macOS with the new rpc server,
the versions that don't need a migration (only the migration that is done by core when opening the account manager) crash on open in the test somehow.
Also this revealed a bug in the core migration for the oldest version:
fix migration function for the cases where it does not detect both accountswas broken testdata