Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-add migration and add tests for it & update core to 1.139.3 #3831

Merged
merged 7 commits into from
May 20, 2024

Conversation

Simon-Laux
Copy link
Member

@Simon-Laux Simon-Laux commented May 18, 2024

This revealed some crash issues on macOS with the new rpc server,
the versions that don't need a migration (only the migration that is done by core when opening the account manager) crash on open in the test somehow.

Also this revealed a bug in the core migration for the oldest version:

  16) migration from DeltaChat.0.840.0.fixed.AppImage works:
     failed to run migrations

Caused by:
    0: execute_migration failed for version 59
    1: unrecognized token: "",
       CREATE INDEX devmsglabels_index1 ON devmsglabels (label);" in ",
       CREATE INDEX devmsglabels_index1 ON devmsglabels (label); at offset 0
    2: Error code 1: SQL error or missing database

@Simon-Laux Simon-Laux changed the title readd migration and add tests for it re-add migration and add tests for it May 18, 2024
@Simon-Laux Simon-Laux added bug Something isn't working technical debt blocker This issue is blocking a new release labels May 18, 2024
@Simon-Laux Simon-Laux force-pushed the simon/bring-back-migration-and-add-tests-for-it branch 3 times, most recently from 6b22f0b to 26e73bf Compare May 19, 2024 15:55
@Simon-Laux Simon-Laux force-pushed the simon/bring-back-migration-and-add-tests-for-it branch from 46a52b8 to 2ab17d4 Compare May 20, 2024 18:27
@Simon-Laux Simon-Laux marked this pull request as ready for review May 20, 2024 19:57
@Simon-Laux Simon-Laux requested a review from link2xt May 20, 2024 19:58
@Simon-Laux Simon-Laux changed the title re-add migration and add tests for it re-add migration and add tests for it /7 update core to 1.139.3 May 20, 2024
@Simon-Laux Simon-Laux changed the title re-add migration and add tests for it /7 update core to 1.139.3 re-add migration and add tests for it & update core to 1.139.3 May 20, 2024
@Simon-Laux Simon-Laux merged commit aafe399 into main May 20, 2024
6 of 7 checks passed
@Simon-Laux Simon-Laux deleted the simon/bring-back-migration-and-add-tests-for-it branch May 20, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker This issue is blocking a new release bug Something isn't working technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant