Add map as internal webxdc widget #3810
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
you could also still have used locally compiled |
Simon-Laux
force-pushed
the
stdio-experiment-with-jikstra
branch
from
b01191b
to
7d3654a
Compare
Todo: - [ ] account migration function in core - [ ] port into own npm module that has all the prebuilds somehow - [ ] ? fix open multiple instances - [ ] code review from "experts" -> fix linereader/performance
…story in the future
I'm still thinking how to simplify that
app source will come in next commit
also reorder some imports in the files that I touched
… lift that restriction for development
…s pr in the end to make sure it does not end up in the main tree as it is quite a large file)
…e that internally)
(mainly to allow the new syntax for importing json from esm modules in `@deltachat/stdio-rpc-server`, but also to) don't mind the local paths too much they will be changed before this pr is merge ready
Simon-Laux
force-pushed
the
stdio-experiment-with-jikstra
branch
from
7d3654a
to
da19267
Compare
- global map can be opened in account context menu - maps stay open on chat switch
nicodh
force-pushed
the
ndh/map-with-json-rpc
branch
from
eef673e
to
eba2923
Compare
Electron < 30.05 crashes on maximize electron/electron#41839
Simon-Laux
force-pushed
the
stdio-experiment-with-jikstra
branch
from
76b9a57
to
a3f1a85
Compare
|
Moved to #3836 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on deltachat/deltachat-core-rust#5541 !!
Depends on non public package @deltachat/stdio-rpc-server !!
Added in chat view and as global map (new)
MR to stdio branch, since the new methods
setWebxdcIntegration
initWebxdcIntegration
do not exist in deltachat-node
tbd: naming of Map Widgets
The title of the Map popup is relevant as it is possible to open multiple wirndows for multiple accounts
We have now:
Maps - Global map for all chats (Account 'AccountName')
Maps - Map for chat 'ChatName'