Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate preview build ci failure #3792

Closed
wants to merge 1 commit into from
Closed

investigate preview build ci failure #3792

wants to merge 1 commit into from

Conversation

Simon-Laux
Copy link
Member

No description provided.

@Simon-Laux
Copy link
Member Author

Simon-Laux commented Apr 25, 2024 •
edited

  • so windows has problems deleting files while doing "npm install"
    • also windows does not use a prebuild like it should because that is missing in the current versions of dc-node
  • and macOS runner is suddenly an arm/M1 runner which makes the action fail (I guess output folder is different)

@Simon-Laux Simon-Laux marked this pull request as draft April 25, 2024 23:47
@Simon-Laux Simon-Laux changed the title try fix preview build ci investigate preview build ci failure Apr 25, 2024
@Simon-Laux Simon-Laux mentioned this pull request Apr 30, 2024
Merged
@Simon-Laux
Copy link
Member Author

windows was fixed meanwhile, macOS seems to still have an error with the output filename, but let's figure that out in a new pr

@Simon-Laux Simon-Laux closed this May 24, 2024
@Simon-Laux Simon-Laux deleted the simon/try-fix-preview-build-ci branch May 24, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Simon-Laux