Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: add CSS transition for adding reaction #3752

Merged
merged 2 commits into from
May 23, 2024

Conversation

WofWca
Copy link
Collaborator

@WofWca WofWca commented Apr 5, 2024

This doesn't add width transition for narrow messages though.

msrdc_RIrlIySUBa.mp4

@WofWca WofWca force-pushed the reaction-margin-transition branch 2 times, most recently from 8046780 to 4845928 Compare April 8, 2024 19:55
@WofWca
Copy link
Collaborator Author

WofWca commented Apr 8, 2024

Please also keep in mind #3753. Maybe fixing that will make this MR irrelevant, but this is a small but nice change.
Edit: I mean that this change can be reverted if required later.

@hpk42
Copy link
Contributor

hpk42 commented May 2, 2024

again, could you rebase and embedd a small video to ease reviewing?

This doesn't add width transition for narrow messages though.
@WofWca WofWca force-pushed the reaction-margin-transition branch from 4845928 to 48b533e Compare May 5, 2024 15:49
@WofWca
Copy link
Collaborator Author

WofWca commented May 5, 2024

Updated

@farooqkz
Copy link
Collaborator

@Simon-Laux The change is so trivial. maybe simply merge it? Or perhaps give me more time to fix #3753

Copy link
Collaborator

@farooqkz farooqkz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice small job!

@Simon-Laux Simon-Laux merged commit bea2a4f into deltachat:main May 23, 2024
5 of 6 checks passed
@WofWca WofWca deleted the reaction-margin-transition branch May 23, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants