feat: Realtime channels #3741
Merged
feat: Realtime channels #3741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Simon-Laux
reviewed
Apr 2, 2024
|
On Tue, Apr 02, 2024 at 09:13 -0700, Simon Laux wrote:
@Simon-Laux commented on this pull request.
> @@ -62,6 +68,10 @@
onStatusUpdate()
return promise
},
+ setEphemeralUpdateListener: (cb) => {
+ ipcRenderer.invoke('webxdc.sendGossipAdvertisement')
like "more info"(linking to inApp Help), "Deny", "Allow" and a checkbox "remember choice for this webxdc app"
would mean you need to track per-app what is allowed, and then allow folks
to change it later -- quite some UI and user-communication effort.
whatsapp and signal enable P2P by default for voice-calls
and have a single global option "always relay calls"/"Protect IP address in calls"
which defaults to "off" for both, and is in advanced options.
Probably makes sense as a global option because either you care or you don't.
ASFAIK iroh/integration is not able to do User1->relay1->relay2->User2 yet so
if i am not mistaken we can not right now offer it like this.
I tentatively suggest to only introduce a global option to
enable/disable ephemeral channels and have translated strings for what it means,
and probably default to off at first.
|
|
I also think that a single configuration option should suffice. Maybe we can talk to the iroh people about our need for IP address protection. |
Simon-Laux
reviewed
Apr 8, 2024
Simon-Laux
added
wait-for-core
Simon-Laux
changed the title
Septias
force-pushed
the
sk/ephemeral_peer_channels
branch
from
210c3d7
to
d14fe53
Compare
Septias
force-pushed
the
sk/ephemeral_peer_channels
branch
from
d14fe53
to
e3c9281
Compare
link2xt
force-pushed
the
sk/ephemeral_peer_channels
branch
2 times, most recently
from
79fb009
to
43b09e5
Compare
Septias
force-pushed
the
sk/ephemeral_peer_channels
branch
from
a3d265a
to
e06913d
Compare
Simon-Laux
reviewed
May 27, 2024
r10s
reviewed
May 27, 2024
Septias
force-pushed
the
sk/ephemeral_peer_channels
branch
from
ebdc81a
to
8530dae
Compare
Simon-Laux
requested changes
May 28, 2024
Simon-Laux
reviewed
May 30, 2024
Simon-Laux
force-pushed
the
sk/ephemeral_peer_channels
branch
from
2283d48
to
31c8fc7
Compare
|
So we decided to squash merge this when the time is ready.
|
link2xt
reviewed
Jun 1, 2024
|
Core PR has been merged |
Septias
force-pushed
the
sk/ephemeral_peer_channels
branch
from
31c8fc7
to
7cddb23
Compare
Co-authored-by: Simon Laux <Simon-Laux@users.noreply.github.com>
Simon-Laux
force-pushed
the
sk/ephemeral_peer_channels
branch
from
7cddb23
to
d823026
Compare
|
It was supposed to be squashed O_O |
|
sorry was in a hurry and annoyed that I needed to fix to the new config key, so I forgot that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of deltachat/deltachat-core-rust#5346
TODO: