include msvc redist files for windows build #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simon-Laux
added
windows
build
Simon-Laux
changed the title
and include msvc redist files for windows build
the electron-builder bug.
because appx dislikes it
Simon-Laux
force-pushed
the
windows_include_vc_redist
branch
from
c228434
to
3d12caf
Compare
Simon-Laux
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
convert electron builder into script and include msvc redist files for windows build
closes #1323
closes #1597
clears the way forcloses #1052Blockers:
electron-builder tries to open the config file with the systems file open mechanism instead of requiring it.doesn't work currently (doesn't find deltachat.dll, as it doesn't work withprobably it was just a broken windows vm, in the end it found the dll but something blocked the event loop on startup, but strangely the packaged build produced by this build works on my other windows vm that I used for testing (clean win 10 install, no extra msvcredist installed)npm run devtoo ,I suspect the used dc node package was broken / or my windows vm)