Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce compilation times by removing duplicate dependencies #870

Closed
link2xt opened this issue Nov 23, 2019 · 4 comments
Closed

Reduce compilation times by removing duplicate dependencies #870

link2xt opened this issue Nov 23, 2019 · 4 comments

Comments

@link2xt
Copy link
Collaborator

link2xt commented Nov 23, 2019

cargo tree -d shows dependencies that are pulled in twice or more because multiple versions of them are required. One example is pgp crate pulling in nom 4, while lettre and imap-proto use nom 5. By updating dependencies or dependencies of dependencies, we can reduce compilation time.

I have opened PR for rPGP that I am going to work on: rpgp/rpgp#78

There are many other duplicate dependencies that seem to be easy to update.

@link2xt
Copy link
Collaborator Author

link2xt commented Nov 24, 2019

One of the reason we use many old versions is the reqwest crate. We need to wait for seanmonstar/reqwest#701 to be merged before we can update it, because we use rustls.

@link2xt
Copy link
Collaborator Author

link2xt commented Nov 24, 2019

To automate dependency upgrades, we can use https://github.com/marketplace/dependabot-preview

It is an official GitHub bot with Rust support, rustls project already uses it.

@hpk42
Copy link
Contributor

hpk42 commented Nov 24, 2019 via email

@link2xt
Copy link
Collaborator Author

link2xt commented Jul 12, 2020

We removed what we could already, not actionable.

@link2xt link2xt closed this as completed Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants