Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove either rustls or rust-native #877

Closed
hpk42 opened this issue Nov 24, 2019 · 2 comments
Closed

remove either rustls or rust-native #877

hpk42 opened this issue Nov 24, 2019 · 2 comments
Projects

Comments

@hpk42
Copy link
Contributor

hpk42 commented Nov 24, 2019

core currently includes two TLS stacks, native and rustls. rust-native does not yet support async -- maybe @dignifiedquire could clarify how far that is away. reqwest (used by core) in turn does not support rustls -- not sure how far that is away. IMO the API of rust-native is much nicer than with rustls but that's not a big inconvenience at this point. We want to get rid of one of the TLS stacks, also to reduce size of the compiled lib which is shipped in the releases. See also #870 how the two-tls situation increases compile times etc. If one of the two stacks leads to a lesser increase in file size, i'd have a preference for that, at least in the longer term.

@hpk42 hpk42 added this to To do in Nov25 via automation Nov 24, 2019
@dignifiedquire
Copy link
Member

That is not quite correct, there is only rustls as of today, if you look at the Cargo.lock there is no refernce to openssl or native_tls

@hpk42
Copy link
Contributor Author

hpk42 commented Nov 24, 2019

ah k, i misunderstood then ... the fact that #870 (comment) is pending only means that we need to use an older version, which then duplicates dependencies but that's tracked in #870 . closing here.

@hpk42 hpk42 closed this as completed Nov 24, 2019
Nov25 automation moved this from To do to Done Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Nov25
  
Done
Development

No branches or pull requests

2 participants