Include trimming of former collapse_whitespace in docs #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I considered the alternative name `collapse_and_trim_whitespace` as too long. Too specific debugging testing was removed from the test to this routine and it was extended with a case that shows a maybe unexpected but proper behaviour.
JKatzwinkel
previously approved these changes
May 19, 2024
It also fixes the edge-case of empty TextNodes.
Both, filter and cache lock, are now consistently enabled once. When used only on a subtree, it is also ensured the DOM has no neighbouring text nodes as the trimming assumes that.
Optimizations are applied as well.
|
sorry, i still realised what was really nagging me there. the last commit is something else but similar. |
JKatzwinkel
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as the promise of pretty serialization will be that its introduced whitespace would vanish when parsing (with the proper option set), i thought it'd be better to clarify how that inverse operates. beyond the slight rewording i opted for another method / option name. explicitly including trim would yield rather long names.